Do not swap with projection when file is partitioned #14956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was referenced Mar 1, 2025
alamb
reviewed
Mar 1, 2025
| Ok(all_alias_free_columns(projection.expr()).then(|| { | ||
|
|
||
| Ok((all_alias_free_columns(projection.expr()) | ||
| && self.table_partition_cols.is_empty()) |
There was a problem hiding this comment.
It seems like the check might be if any of the columns needed are in the table_partition_cols (rather than there just being partition columns at all) 🤔 Or something like that
blaginin
force-pushed
the
bugfix/do-not-swap-proj-for-paritions
branch
from
88695a2 to
55f8b30
Compare
This was referenced Mar 2, 2025
|
I made a small follow on: |
alamb
pushed a commit
to alamb/datafusion
that referenced
this pull request
Mar 2, 2025
* Do not swap with projection when file is partitioned * Narrow the case when not swapping * Add test
alamb
added a commit
that referenced
this pull request
Mar 2, 2025
* Do not swap with projection when file is partitioned * Narrow the case when not swapping * Add test Co-authored-by: Dmitrii Blaginin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
I feel like there should be a way to apply swapping even if the file is partitioned - but submitting a hotfix since it's a release blocker
What changes are included in this PR?
Are these changes tested?
Added a test
Are there any user-facing changes?
No